fix: bump http.client._MAXHEADERS to 1000 to prevent CDN header drops - #1033
Open
NicoleXeon wants to merge 1 commit into
Open
NicoleXeon wants to merge 1 commit into
NicoleXeon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Certain CDNs (notably Akamai/Qobuz edge nodes on high-profile releases like
https://open.qobuz.com/track/212116885) return over 100 response headers, primarily bloated cookie and telemetry headers.Because Python's standard
http.clienthardcodes an internal limit of 100 headers (_MAXHEADERS = 100), requests abort immediately with:Solution
Increases http.client._MAXHEADERS to 1000 in streamrip/init.py during startup, allowing requests to complete successfully across all affected CDN endpoints without breaking downloads.