stream: apply more stream/iter fixes, round 3 by jasnell · Pull Request #66079 · nodejs/node

jasnell · 2026-09-17T06:29:24Z

See each individual commits.

~~Stacks on #66030 the first seven commits here are from there.. this will remain draft until that lands~~

nodejs-github-bot · 2026-09-17T06:29:30Z

Review requested:

@nodejs/quic
@nodejs/streams

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

Signed-off-by: James M Snell <jasnell@gmail.com>

Just say no to `new Promise(() => timer(...))` use promisified timers Signed-off-by: James M Snell <jasnell@gmail.com>

codecov · 2026-09-22T18:02:06Z

Codecov Report

❌ Patch coverage is 99.56647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (c0ed28f) to head (71c2c02).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/iter/classic.js	99.38%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66079      +/-   ##
==========================================
+ Coverage   90.29%   90.32%   +0.02%     
==========================================
  Files         790      790              
  Lines      272883   273285     +402     
  Branches    52118    52235     +117     
==========================================
+ Hits       246387   246831     +444     
+ Misses      16943    16920      -23     
+ Partials     9553     9534      -19

Files with missing lines	Coverage Δ
lib/internal/quic/quic.js	`100.00% <100.00%> (ø)`
lib/internal/streams/iter/broadcast.js	`90.55% <100.00%> (+0.04%)`	⬆️
lib/internal/streams/iter/pull.js	`83.87% <100.00%> (+0.05%)`	⬆️
lib/internal/streams/iter/share.js	`89.35% <100.00%> (+0.03%)`	⬆️
lib/internal/streams/iter/transform.js	`97.61% <100.00%> (+1.77%)`	⬆️
lib/internal/streams/iter/classic.js	`96.45% <99.38%> (+7.48%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

nodejs-github-bot · 2026-09-24T03:29:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77818/

nodejs-github-bot · 2026-09-24T18:47:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77853/ 💚

nodejs-github-bot · 2026-09-24T23:06:26Z

Landed in f950eb8...847da07

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Just say no to `new Promise(() => timer(...))` use promisified timers Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 17, 2026

stream: make stream/iter toWritable apply backpressure

543436c

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

jasnell force-pushed the jasnell/moar-iter-streams-3 branch from 8bc2e10 to 345be6c Compare September 22, 2026 16:26

jasnell added 6 commits September 22, 2026 16:27

stream: correct strict pending-write behavior & cancellation

77dafe6

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

stream: make classic reads wake on return/throw/abort

f578f9c

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

stream,quic: correct stream/iter writer implementations

0e1a293

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

doc: fixup and cleanup stream/iter docs

b02dcf6

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

stream: cleanup promise uses in stream/iter

f3910f2

Signed-off-by: James M Snell <jasnell@gmail.com>

test: avoid using promise wrapped timers

0b2fffe

Just say no to `new Promise(() => timer(...))` use promisified timers Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell force-pushed the jasnell/moar-iter-streams-3 branch from 345be6c to 0b2fffe Compare September 22, 2026 16:27

jasnell requested review from mcollina, ronag and trivikr September 22, 2026 16:27

jasnell marked this pull request as ready for review September 22, 2026 16:27

stream: fill out stream/iter test coverage

71c2c02

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode

trivikr approved these changes Sep 23, 2026

View reviewed changes

jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 24, 2026

panva added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Sep 24, 2026

github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Sep 24, 2026

This comment was marked as outdated.

Sign in to view

panva removed the resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. label Sep 24, 2026

This comment was marked as outdated.

Sign in to view

jasnell added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Sep 24, 2026

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream: make stream/iter toWritable apply backpressure

0d4a844

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream: correct strict pending-write behavior & cancellation

04f1b72

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream: make classic reads wake on return/throw/abort

8fc9838

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream,quic: correct stream/iter writer implementations

fe1a203

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

doc: fixup and cleanup stream/iter docs

fc78459

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream: cleanup promise uses in stream/iter

bf4bd44

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2026

stream: fill out stream/iter test coverage

847da07

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #66079 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot closed this Sep 24, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 24, 2026

Navigation Menu

Uh oh!

stream: apply more stream/iter fixes, round 3 - #66079

stream: apply more stream/iter fixes, round 3#66079
jasnell wants to merge 8 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-3

jasnell commented Sep 17, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Sep 17, 2026

Uh oh!

codecov Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Sep 24, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 24, 2026 •

edited by jasnell

Loading

Uh oh!

nodejs-github-bot commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jasnell commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 17, 2026

Uh oh!

codecov Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Sep 24, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 24, 2026 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jasnell commented Sep 17, 2026 •

edited

Loading

codecov Bot commented Sep 22, 2026 •

edited

Loading

nodejs-github-bot commented Sep 24, 2026 •

edited by jasnell

Loading