Skip to content

doc: document iterable input for AbortSignal.any - #66123

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
haramj:codex/doc-abortsignal-any-iterable
Sep 22, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
haramj:codex/doc-abortsignal-any-iterable

Conversation

@haramj

@haramj haramj commented Sep 19, 2026

Copy link
Copy Markdown
Member

AbortSignal.any() accepts an iterable of AbortSignals, but its parameter
documentation currently lists only an array. Describe the input as an
Iterable so callers can see that other iterable objects are supported.

Validation:

  • Markdown lint passed for doc/api/globals.md.
  • All 13 existing test-abortsignal-any.mjs tests passed using the available
    local v27.0.0-pre build. This was not a rebuild of the latest main.
  • git diff --check passed.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 19, 2026
Describe signals as an iterable of AbortSignals, matching the WebIDL
sequence conversion and the existing iterable test.

Signed-off-by: haramjeong <04harams77@gmail.com>
Assisted-by: Codex
@haramj
haramj force-pushed the codex/doc-abortsignal-any-iterable branch from 809b765 to 84943e6 Compare September 19, 2026 04:55
@haramj
haramj requested a review from lpinca September 19, 2026 05:45
@inoway46 inoway46 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 22, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Sep 22, 2026
@haramj

haramj commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

@lpinca Could you please take a look at this quick doc fix when you have a moment? It requires a second approval to be merged. Thank you!

Comment thread doc/api/globals.md Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 3cd2d6e into nodejs:main Sep 22, 2026
22 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 3cd2d6e

@nodejs-github-bot nodejs-github-bot removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants