Conversation
Stopping the loop on SIGTERM, SIGINT, or Cmd+Q skipped Window.onClose and Application.onExit, so those events were neither dispatched nor cancelable. Fall back to stopping only when no window is open. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL_QUITfor application-external exits (SIGTERM/SIGINTvia its default handlers, Cmd+Q on macOS). The SDL backend treated that asactive = false, so the loop stopped,Quit()tore SDL down, and only then didlime_application_execreturn and dispatchApplication.onExit.Window.onCloseentirely.onExitis documented as cancelable, but by then it could not cancel anything. OpenFL'sNativeApplication"exiting"(emitted from__checkForAllWindowsClosed) never fired either, so AIR-style shutdown andpreventDefault()did not work on those paths.SDL_QUITas aWINDOW_CLOSEon every registered window (iterate a copy, since close unregisters). Stop the loop only when no window is open; SDL also raisesSDL_QUITafter the last window is destroyed.