Skip to content

Allow caller to deal with failure #15

Description

@TyeMcQueen

Please update the "unsupported" case to be more useful. You could provide a browser.IsSupported() that returns true only on supported platforms.

I find the use of build-time handling of different platforms to be overly complex. After reviewing this module and considering writing a pull request, I just went with:

func openBrowser(url string) {
	cmd := "xdg-open"
	args := []string{url}

	switch runtime.GOOS {
	case "darwin":
		cmd = "open"
	case "windows":
		cmd = "rundll32"
		args = []string{"url.dll,FileProtocolHandler", url}
	}
	err := exec.Command(cmd, args...).Start()
	if err == nil {
		return
	}
	fmt.Printf("Failed to launch %s: %v", cmd, err)
	fmt.Printf("Load this URL in your browser:\n    %s\n", url)
}

because it could work on more types of Unix systems and more gracefully fails when assumptions are not met.

Adding support for the BROWSER environment variable to that would be even better.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions