Track device descriptors by Playwright release - #9
Merged
smnandre merged 2 commits intoSep 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The newly analyzed updater passes a potentially false cURL handle to functions requiring CurlHandle, blocking strict static analysis.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: None
What changed in this PR
Tracks device descriptors by stable Playwright release and adds automated freshness reporting.
Changes:
- Refreshes descriptors from Playwright 1.63.0 and records provenance.
- Adds reusable update/check tooling with semantic reports and tests.
- Adds nightly verification and patch-producing update workflows.
| File | Description |
|---|---|
tests/UpdateDevicesTest.php |
Tests version parsing, generation, and reports. |
README.md |
Documents release tracking and update commands. |
phpstan.dist.neon |
Adds scripts to static analysis. |
docs/DEVICES.md |
Records the source release. |
data/playwright-version.txt |
Stores Playwright 1.63.0. |
data/devices.php |
Refreshes generated user agents. |
bin/update-docs.php |
Uses recorded version in documentation. |
bin/update-devices.php |
Updates catalog, version, and report. |
bin/update-devices-functions.php |
Provides shared generation and diff helpers. |
bin/check-devices.php |
Verifies catalog freshness. |
.gitignore |
Ignores downloaded source JSON. |
.github/workflows/update.yaml |
Produces reports and update patches. |
.github/workflows/Nightly.yaml |
Adds nightly freshness checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
smnandre
force-pushed
the
chore/track-playwright-release
branch
from
September 20, 2026 16:47
3a6331d to
cf0445f
Compare
Merged
smnandre
added a commit
that referenced
this pull request
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device catalog currently does not record which stable Playwright release produced it, and freshness checks cannot explain upstream changes. Refresh the catalog from Playwright 1.63.0, record that source release, and make the update and check commands resolve the latest stable Playwright version by default.
The commands now emit a semantic Markdown report covering added, removed and changed devices and property-level changes. Nightly CI detects stale generated data, while the manual update workflow exposes the same report and uploads the generated patch.