Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clean --include cocoapodspasses~/.cocoapodsdirectly to filesystem APIs, which do not expand the tilde. It also removesios/Podsrelative to the current working directory rather than the selected project. This leaves the intended caches behind and can clean the wrong project when running from another directory.Resolve the spec cache using
os.homedir(), and resolve installed pods fromproject.ios.sourceDir, falling back toiosunder--project-root. Document the CocoaPods cleaning paths.Test Plan
Validated with Node 22.16.0:
ios/Podsand literal~/.cocoapodsdirectories in the working directory. The externalpodcommand is mocked.yarn build, including TypeScript declarations: passed.yarn lint: passed with two existing warnings in unchanged files.git diff --check: passed.No real user CocoaPods cache was cleaned and no native React Native checkout integration test was performed.
Checklist
react-nativecheckout (instructions).