Tweak new extensions module - #456
Merged
Merged
Conversation
ctz
approved these changes
Sep 21, 2026
cpu
approved these changes
Sep 21, 2026
cpu
left a comment
cpu
left a comment
Member
There was a problem hiding this comment.
Thanks!
For some of these, it feels like the from_params() pattern is a little overwrought? Like, if there's only one params field, can't we do something simpler? Or does some of the rework in 454 depend on the uniformity here?
I don't think 454 necessarily depends on the uniformity, I just thought it was a nice pattern for keeping things consistent & easy to review. I'm open to changing on a case-by-case basis if you prefer an alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some followup from
For some of these, it feels like the
from_params()pattern is a little overwrought? Like, if there's only one params field, can't we do something simpler? Or does some of the rework independ on the uniformity here?