Allowing empty nodes for Company, GivenName, SurName and Telephone elements of ContactPerson in Metadata - #5
Merged
Merged
Conversation
AD FS-generated metadata (e.g. SVEA) emits self-closing <TelephoneNumber/> elements which fail XS.xpString (xpTextDT requires non-empty text). Switch to XP.xpText0 so empty bodies parse as the empty string.
Same rationale as TelephoneNumber: AD FS-style metadata may emit self-closing string-typed contact children. Use xpText0 so they parse as the empty string instead of failing xpTextDT.
arybczak
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is with certain SAML IDP's that expose metadata with
ContactPersonelement containing empty nodes (instead of not including them). According to the spec those fields are not mandatory (and thats pretty much it about them) and this can be understood in a different way.