Add csi-addons Phase 0 prerequisites: replication status read, idempo… - #1372
geoffrey1330 wants to merge 10 commits into
Conversation
…tent attach/detach, rpo_target_seconds
mxsrc
left a comment
mxsrc
left a comment
There was a problem hiding this comment.
Some notes about the types used in the API. Please try to use type annotations on all functions you introduce.
| #: The declared RPO objective (P0-4); null when the operator declared | ||
| #: none, in which case the derived lag budget applies. | ||
| rpo_target_seconds: int | None = None |
There was a problem hiding this comment.
Does this mean the value can only be in the [0,4] interval? If that is the case, please annotate that constraint.
There was a problem hiding this comment.
No, the P0-4 is the phase( phase 0 item 4). this how i track the task to implement. it makes it easier for agent to keep track of what is implemented and what is not yet.
There was a problem hiding this comment.
I see. That makes perfect sense but it shouldn't end up in the code. Without the planning document you're iterating on it's impossible to understand what's meant.
There was a problem hiding this comment.
Alright. I will remove them before the merge
…mpler status route
…w rpo_target_seconds and group_seq to unsigned
…emote endpoint and planned-gate force-escalation fix
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| raise HTTPException(500, str(result[1])) | ||
| if result["demoted"]: | ||
| return Response(status_code=204) | ||
| return JSONResponse(status_code=202, content=result) |
3 participants
…tent attach/detach, rpo_target_seconds