Skip to content

Fix initialCount prop to count in CounterProvider #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deniznehlyadyuk wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix initialCount prop to count in CounterProvider #1639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/(0)concepts/(4)context.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export function App() {
import { createSignal, useContext } from "solid-js";

export function CounterProvider(props) {
const [count, setCount] = createSignal(props.initialCount || 0);
const [count, setCount] = createSignal(props.count || 0);

@brenelz brenelz Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost think initialCount is more clear

@deniznehlyadyuk deniznehlyadyuk Sep 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change wasn’t really about the naming itself. I changed it to count because that’s the prop name being passed to the other CounterProvider component, so I wanted to keep them consistent.

If keeping initialCount here makes more sense, I think we should also consider changing the prop passed to CounterProvider from count to initialCount for consistency.

I’m happy to make the necessary changes based on your preference.

@deniznehlyadyuk deniznehlyadyuk Sep 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid-docs/src/routes/(0)concepts/(4)context.mdx

Line 170 in bb081ef

<CounterProvider count={1}>

const counter = [
count,
{
Expand Down
Loading