Accept extended splats when writing SPZ - #440
Open
oscarlorentzon wants to merge 2 commits into
Open
oscarlorentzon wants to merge 2 commits into
oscarlorentzon wants to merge 2 commits into
Conversation
The loader stopped using these types when the function taking them moved away. The argument type is now exported too, so callers can name what they pass.
Only the packed container was accepted, so extended splats had to be converted first, rounding their positions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeSpzaccepted onlyPackedSplats, so anExtSplatscould not be written.ExtSplatsis now accepted too, and its positions reach the encoder as the 32 bit floats it stores rather than the half floatsPackedSplatsholds. Calls that pass aPackedSplatsstill work. The types describing whattranscodeSpzaccepts are now exported, so an application can import them instead of restating the shape.