Conversation
AMRClaim.IsAAL2Claim dereferenced AuthenticationMethod (a *string mapped to the nullable authentication_method column) without a nil check, while the sibling GetAuthenticationMethod guards the same field. A mfa_amr_claims row with a NULL authentication_method would panic in Session.CalculateAALAndAMR — a hot path during token refresh, MFA verification and session AAL computation — turning it into a 500. Treat a nil method as not AAL2 and add a regression test for the nil case.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AMRClaim.IsAAL2ClaimdereferencesAuthenticationMethodwithout a nil check:AuthenticationMethodis a*stringmapped to the nullableauthentication_methodcolumn. The sibling accessorGetAuthenticationMethodright below already guards the same field withif a.AuthenticationMethod == nil, so the pointer is known to be nullable.A
mfa_amr_claimsrow with a NULLauthentication_methodtherefore panics here.IsAAL2Claimis called fromSession.CalculateAALAndAMR, which runs on hot paths (token refresh, MFA verification, session AAL computation), so the panic surfaces as a500.Fix
Guard the pointer (mirroring
GetAuthenticationMethod) and treat a nil method as "not AAL2".Testing
Extended
TestAMRClaimIsAAL2with anilcase assertingIsAAL2Claim()returnsfalsewithout panicking.go vetandgofmtare clean; the models test passes.