fix: accept base64url-encoded nonce in id_token grant - #2822
Open
sushrut1058 wants to merge 2 commits into
Open
sushrut1058 wants to merge 2 commits into
sushrut1058 wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In the
id_tokengrant, nonce verification only compares the request nonce against its hex-encoded SHA-256:Apple returns the
nonceclaim as base64url(SHA-256(nonce)), so this hex comparison can never match andSign in with Applethrough the id_token grant always fails with "Nonces mismatch".What is the new behavior?
Nonce verification now accepts the request nonce hashed as either hex or base64url (unpadded) SHA-256. The hex path is unchanged (backward compatible) and the base64url path fixes Apple.
Fixes #2378
Additional context
Adds a unit test for the comparison helper covering both encodings and rejecting raw / echoed-hash values.