Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Better memoization/caching #9

Description

@osolmaz

Feedback from Eden:

The caching method is interesting, although I would've expected memoized responses first, then falling back to your file cache on miss.

I think you're also mixing caches between models, as they rely on the same file location.
You likely want to either just have a session cache via memoised patterns - functools has a very simple one to add in - or you want to break up caches between models and services.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions