fix(ci): ruboCop excludes the whole test directory while the Gemfile - #117
Open
ronitkhokharr wants to merge 580 commits into
Open
ronitkhokharr wants to merge 580 commits into
ronitkhokharr wants to merge 580 commits into
Conversation
…s-dedicated-push-queue-20260828 Fix Mobile Notifications push queue delivery
…al-security-evidence-20260827 test(security): tighten FILE-S01 evidence and log privacy
…st-comments-11x-20260827 docs(notifications): correct Edge WNS host guidance on 11.0.x
…ime-followup-20260828 ci: reduce full API test runtime
…es-assess fix(tasks): require assessment permission to set a task grade
…er-results-to-project fix(overseer): scope assessment results to the authorised project
…sions-on-finalised-tasks fix(submission): refuse student uploads to a finalised task
…-deadline-calc fix(tasks): grant the resubmission extension once per round of feedback
…s-status-authorisation fix(scorm): authorise the success status wherever it is written
…sition-403 fix(tasks): return 403 when a status transition is refused
…okup-on-asserted-identity fix(auth): match a federated assertion only on what it asserts
…en-to-subject fix(lti): bind an enrolment token to its subject and make it single use
…n-set-per-recipient-delivery-errors fix(communications): keep sending when one recipient's delivery fails
…ification-route-20260828 fix(notifications): open feedback alerts in the feedback pane
Exercise the production application configuration with isolated synthetic credentials and verify individual and combined missing-key diagnostics.
Removes .rspec, .overcommit.yml, FETCH_HEAD, docs/README_FOR_APP, and the unreferenced User.default method. Adds FETCH_HEAD to .gitignore. Deletion only, no behaviour changed. Includes Minitest coverage confirming the deletions and that User.default no longer exists.
…rejection-logging-20260920 fix(uploads): make rejected uploads visible in production logs
…loads-remaining-20260920 feat(uploads): complete safe spreadsheet and chat attachment support
…ion-lifecycle-remaining-20260920 feat(submissions): complete lifecycle controls and reliable deadline events
…-infra-20260920 fix(config): identify each missing production secret (PR-PLAT-10)
…pi-20260920 feat(tutorial): add rollout flag and complete API handover tasks
docs(dx-a02): Four dead config and scaffold files tracked in doubtfire-api, plus one unreachable model method.
ronitkhokharr
force-pushed
the
fix/tci-03
branch
from
September 21, 2026 09:26
94b6857 to
c99ecf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses TCI-03 by enabling RuboCop coverage for the test suite and loading the RuboCop extensions that are already included in the Gemfile.
Previously,
.rubocop.ymlexcludedtest/**/*, whilerubocop-minitestandrubocop-factory_botwere installed but not loaded. As a result, test files were excluded from the normal RuboCop run and the Minitest/FactoryBot-specific cops were inactive.Changes
test/**/*fromAllCops.Exclude.rubocop-minitest.rubocop-factory_bot..rubocop_todo.ymlusingbundle exec rubocop --auto-gen-configagainst the current upstream11.0.xbase so existing offences are baselined while CI remains green.test/config/rubocop_configuration_test.rbas a regression test for the required RuboCop configuration.RuboCop Configuration
The updated configuration now ensures that:
testdirectory is included in RuboCop analysis.rubocop-minitestis loaded.rubocop-factory_botis loaded..rubocop_todo.ymlrather than excluding the entire test directory.Auto-Generated Baseline
The RuboCop todo was regenerated against the current upstream
11.0.xcodebase.Phase 1: