Skip to content

Vouch request: adem-loghmari — CLI/docs fixes (#4425, #4782) #4974

Description

@adem-loghmari

Why do you want to contribute?

I'm a full-stack TypeScript engineer (Next.js / React / Node) and I work on background-job and queueing code day to day, which is what drew me to Trigger.dev. I'd like to start with small, self-contained, verifiable fixes rather than anything sweeping:

  • docs: dev --env-file help/docs say it does not reach tasks, but it does #4425 — the --env-file help text and the cli-dev-commands / cli-deploy-commands / cli-preview-archive docs all say the file "will only hydrate the process.env of the CLI process, not the tasks", but in dev the file is passed through to the run environment. The docs and the behaviour disagree, so one of the two should move; happy to fix the wording, or the behaviour, whichever the team considers correct.
  • 3 code samples in your docs no longer compile #4782 — three docs samples (PromptHandle, PromptIdentifier, PromptVariables on the Prompts page) reference exports that no longer exist in @trigger.dev/sdk, so they no longer type-check.

Both are low-risk and easy to verify, which seemed like the right way to start.

For transparency: I opened #4035 back in June (docs typo fixes) before I understood how vouching worked here, and it was auto-closed. I'd rather ask first this time than have another PR closed by the bot.

Prior contributions or relevant experience

Merged open-source work, all small focused fixes of the same kind:

GitHub profile: https://github.com/adem-loghmari

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions