fix(demo): stop delaying the trust prompt; it cannot be avoided - #29
Merged
Merged
Conversation
Four fresh Codespaces on 2026-09-11 all opened untrusted and all raised "Do you trust the authors of the files in this folder?" as soon as the startup terminal asked to execute code. The ten-second wait added in #28 did not prevent it — it only moved the same modal later, after a pause in which the demo looked broken. So the terminal starts immediately again. The question arrives at once, DEMO.md says what to click, and nothing here pretends the prompt is avoidable: an earlier attempt via `security.workspace.trust.*` was ignored because those keys are user-scope by design. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the mitigation from #28, which I verified does not work.
Evidence
Four fresh Codespaces (2026-09-11) all opened untrusted and all raised "Do you trust the authors of the files in this folder?":
drift analyzesecurity.workspace.trust.*settings (#27)sleep 10 &&(#28)Until it is answered the extension never activates (
untrustedWorkspaces.supported: false): no panel, no analysis, no terminal.This PR
Back to
postAttachCommand: drift analyze < /dev/null, so the question arrives immediately instead of after a pause in which the demo looks broken. DEMO.md (added in #28) keeps telling the visitor what to click.The comment now records what was tried and why it failed, so the next person does not attempt either fix again.
Follow-up (not here)
The extension could handle this far better: declaring
untrustedWorkspaces: limitedwould let the panel say "trust this folder so Drift can analyse it" and re-run ononDidGrantWorkspaceTrust, instead of showing nothing — the same "silence instead of explanation" failure fixed in trydrift/drift#272.🤖 Generated with Claude Code