Bump rustls to 0.23.45 for RUSTSEC-2026-0285 - #69
Merged
Merged
Conversation
cargo-audit is red on main against rustls 0.23.40. Lockfile-only update to latest compatible 0.23.x (0.23.45); rustls-webpki follows 0.103.13 -> 0.103.15. No Cargo.toml pin, no new audit ignores. Co-authored-by: Lundin Matthews <lundinmatthews@me.com>
Contributor
|
Thank you for your contribution! Before we can merge this PR, you need to sign our Contributor License Agreement. Please read the CLA and post the following comment to sign:
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
hkd987
marked this pull request as ready for review
September 21, 2026 12:03
hkd987
commented
Sep 21, 2026
hkd987
left a comment
hkd987
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — lockfile bump rustls 0.23.40→0.23.45 (+ rustls-webpki) clears RUSTSEC-2026-0285. cargo-audit green; CLA flake ignored. Merging when Check is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for cargo-audit going red on main (and on Dependabot #68 clap bump). Do not land this on #68; that PR did not cause the advisory.
The advisory
RUSTSEC-2026-0285/ TLS 1.3 handshake messages incorrectly accepted across encryption level boundaries. Againstrustls 0.23.40(medium, 5.3). Patched inrustls >= 0.23.45. rustls is not a direct dependency — it sits underreqwest(rustls-tls) andlettre(tokio1-rustls-tls).Reproduced on current
mainCargo.lockwith cargo-audit 0.22.1:error: 1 vulnerability found!(rustls 0.23.40).The fix
Same shape as #37 (h2) and #40 (chacha20): lockfile-only, no
Cargo.tomlpin, no new audit ignore.cargo update -p rustlson current main:rustls0.23.40 → 0.23.45 (latest compatible 0.23.x)rustls-webpki0.103.13 → 0.103.15 (required companion)Resolver also unified a few
windows-sysedges from 0.52.0 to 0.59.0 (already present in the lockfile). No ignore entry: an upstream patch exists.Verification
mainlockfile: cargo-audit 0.22.1 reportsRUSTSEC-2026-0285against rustls 0.23.40../scripts/cargo-audit-gate.sh→✓ cargo-audit-gate passed (3 advisories on the documented ignore list).cargo auditon this PR head: success.cargo metadata --lockedcleancargo check --locked --all-targetscleancargo clippy --locked --all-targets -- -D warningscleancargo fmt --all -- --checkcleancargo test --all --locked— 2141 passed, 0 failed (6 ignored)Do not merge this PR or #68 from this work.