Skip to content

feat: add Welsh translations - #492

Merged
driaug merged 6 commits into
useplunk:nextfrom
danryland:codex/add-welsh-locale
Sep 20, 2026
Merged

driaug merged 6 commits into
useplunk:nextfrom
danryland:codex/add-welsh-locale

Conversation

@danryland

@danryland danryland commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add Welsh (cy) to the supported language list as Cymraeg
  • register the Welsh locale bundle
  • translate unsubscribe, re-subscribe, preference management, snoozing, and email footer copy using informal Welsh
  • encode the Welsh flag with explicit Unicode escapes so it renders correctly without triggering GitHub hidden-Unicode warnings

Validation

  • yarn workspace @plunk/shared build
  • Prettier check for all three changed files
  • locale key parity with English: 44 of 44 keys
  • interpolation placeholder parity with English
  • verified the escaped flag evaluates to the complete Wales emoji sequence
  • git diff --check

@driaug

driaug commented Sep 20, 2026

Copy link
Copy Markdown
Member

Is there a specific technical reason you encoded the Welsh flag?

If it is just to get rid of the hidden character warning from GitHub then there is no need, you may just use the emoji directly.

@danryland

Copy link
Copy Markdown
Contributor Author

@driaug Yes, it was to get rid of the Github warning. Reverted to emoji flag now. Thanks!

@driaug
driaug merged commit 9457556 into useplunk:next Sep 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants