Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitdefender CEF records marked blocked phishing, port scans and incidents as successful, and incident src values could replace the managed endpoint address. This draft repairs the raw-field producer and all 21 consumers against go-sdk v1.1.31 and the official wiki.
Validation: 80 synthetic raw CEF cases, positive/negative predicates for all 21 rules, five real-SDK mock-history suites, and a private replay of 35 bounded records from three instances. The shared-runner overlay passes 112 test/subtest records with no failures or skips. The replay preserves all module values, corrects three endpoint addresses and maps 24 explicit blocks to denied. Predicate candidates are not observed alerts or measured false-positive rates. Privacy scanning found no sampled identifying literals in the 27 changed files.
Limits: the documented pipeline lacks general CEF unescaping. Encoded Windows directories/commands and partial URLs remain in original vendor fields; safe basenames and request domains still map. The available vendor page documents JSON semantics rather than a complete CEF mapping table. Unobserved classes, closed-runtime behavior, parser cost and alert-volume effects need staging. New history fields require up to 24 hours of warm-up. Details and migration notes are in filters/audits/bitdefender.md.
Filter and rules must ship together. Shared indexed-lastEvent grouping support is a separate dependency and fleet-wide rollout in #2627. No customer writes, deployment, merge or auto-merge is included.
Fresh draft review submission requested after review of #2591. That earlier PR is retained as historical context and was not modified by this publication. This PR targets the official
utmstack/UTMStack:v11; it is not approved for merge.A final endpoint-role check keeps reporting-device host/domain/user metadata off unrelated victim addresses. Explicit attacker/victim addresses remain authoritative; local-port mapping requires the reporting endpoint to be the victim. Three additional raw controls cover this boundary.