Fix repository searches for the string zero - #264
Draft
HarshMN2345 wants to merge 1 commit into
Draft
HarshMN2345 wants to merge 1 commit into
HarshMN2345 wants to merge 1 commit into
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository searches for the literal string
0currently return unfiltered repositories because the adapters treat it as an empty search. Preserve the query for GitHub, Gitea, Forgejo, Gogs, GitLab, and Bitbucket while keeping an empty string as the request for all repositories.The GitHub path filters selected installation repositories before pagination. Provider-backed searches now include
0in the outbound query, including GitLab's personal-namespace fallback. Origin already preserves the value and requires no change.Validation: 15 focused tests pass (17 assertions), covering zero and empty searches across providers and GitHub pagination. Eight regressions fail against the original adapters. The complete package unit suite passes: 103 tests, 394 assertions, one existing skip.
bin/monorepo check vcs(Pint, PHPStan level 5, Rector),bin/monorepo validate, andgit diff --checkpass. Tests use local provider fakes and make no external requests.CI passed package checks (Pint, PHPStan, Rector) and the complete unit suite: 103 tests, 394 assertions, one existing skip. Provider E2E tests did not start: the unchanged GitHub authentication preflight rejected the configured app identifier with HTTP 401 (
errorCategory: issuer; the identifier was neither numeric nor a client ID beginning withIv1.). CI credentials need correction before provider E2E validation can complete. Failed job log.Appwrite must preserve the query at its API boundary and adopt a released package version before this behavior reaches Appwrite users. That consumer patch and Gitea API regression are prepared separately, pending dependency adoption.