Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Node 20 の EOL 対応のため、
.github/workflows/ci.yml,.github/workflows/review.ymlのactions/checkoutを v2 から v7 に、.github/workflows/ci.ymlのcodecov/codecov-actionを v1 から v7.1.0 に上げます。 https://github.com/wantedly/infrastructure/issues/16098actions/checkoutは v5 で node20 から node24 に移行しているため、v5 以上であれば Node 20 EOL の要件を満たします。codecov/codecov-actionは v3 で node16 化、v4 で node20 化していますが、これも Sept 2026 の Node 20 削除で動かなくなるため、composite action (Node ランタイム非依存) になっている v7 系まで上げました。破壊的変更の確認
ubuntu-latest/macos-latest(GitHub ホステッド) のみ使用のため影響なしpull_request_target/workflow_runでの fork PR checkout をブロックfail_ci_if_errorのデフォルトはfalseのままのため、アップロードが失敗しても CI 自体は失敗しないfile入力が非推奨化 (filesへ)file: ./coverage/coverage.xmlを使用していたためfiles:に修正した保留・要相談
codecov/codecov-actionの CODECOV_TOKEN の設定有無は当方からは確認できませんでした。未設定の場合、アップロード自体はスキップ/失敗しますがfail_ci_if_error: false(デフォルト) のため CI は red になりません。CI 結果を見てアップロードが実際に成功しているか確認してください。🤖 Generated with Claude Code