Conversation
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2895 +/- ##
=======================================
Coverage 92.18% 92.19%
=======================================
Files 657 658 +1
Lines 20610 20636 +26
Branches 4570 4574 +4
=======================================
+ Hits 18999 19025 +26
Misses 1607 1607
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Client artifacts: |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
|
📅 Suggested merge-by date: 9/30/2026 |
traeok
left a comment
There was a problem hiding this comment.
Thanks for working on this Pujal! I think the snapshots are failing due to a merge commit that left behind conflict markers across multiple files. See my comment below.
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
anaxceron
left a comment
There was a problem hiding this comment.
Requesting some minor edits
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
|
Kicked off a round of system tests for your PR, job number 2656 👍 |
|
Requested changes have been implemented; system tests in job 2656 are all passing
traeok
left a comment
There was a problem hiding this comment.
Thanks for working on this Pujal! I left a suggestion but it may be out of scope - I noticed the definition for authOrder was just added so I wanted to mention it while those changes were new. Aside from that, I think the changes should be good to merge
| */ | ||
| public static readonly BASE_OPTION_AUTH_ORDER: ICommandOptionDefinition = { | ||
| name: "auth-order", | ||
| description: "A comma separated list of authentication types, in order of precedence, " + |
There was a problem hiding this comment.
I like that we provide the allowable values and an explanation of the default for the new allowedLoginMethod option. In a similar fashion, should we provide the allowed values in this description of authOrder for clarity?
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| All notable changes to the Zowe z/OSMF SDK package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
| - Enhancement: Added `allowedLoginMethod` and `AuthOrder` options to the z/OSMF profile/schema, allowing users to specifiy those properties to use for z/OSMF operations. [#2653](https://github.com/zowe/zowe-cli/issues/2653) | |||
There was a problem hiding this comment.
(nitpick) space missing between header and entry



What It Does
As an administrator of Team Config files at my site, I would like the ability to indicate which authentication principals users should be prompted to submit when they're logging into services so they are are entering the credentials which are compliant with my site requirements and backend configuration.
How to Test
See each scenario listed pass in unit tests
Review Checklist
I certify that I have:
Additional Comments