Skip to content

Consolidate tabs review - #8525

Merged
jonathanawesome merged 2 commits into
consolidate-tabsfrom
consolidate-tabs-review
Sep 21, 2026
Merged

jonathanawesome merged 2 commits into
consolidate-tabsfrom
consolidate-tabs-review

Conversation

@jdolle

@jdolle jdolle commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Background

A review of the consolidate-tabs branch turned up a few regressions and gaps introduced by the migration from ui/tabs onto the Base UI components. This change addresses them; nothing here touches the seed script or the visual restyling.

Description

Schema check page

  • The contract picker no longer loses keyboard focus when a contract is picked. DefaultSchemaView and ContractCheckView are now hooks that return tab items, and the page renders a single TabbedView, so switching graphs swaps the tabs instead of remounting the band the picker sits in.
  • A contract's view resets to Details when a different contract is picked.
  • Checks without contracts show the default graph's status glyph and tooltip again, in the picker's slot.
  • The Commit cell has hover text for the full hash.

Schema version page

  • Versions without contracts show the default graph's status glyph again; the legend only appears when contracts exist.

Base Tabs / TabbedView

  • A tab activated from outside the strip (a service just added to a proposal) is scrolled into view. Clicks and arrow keys already scroll via focus; this covers the programmatic case the old editor handled itself. Only the strip scrolls, never the page.

Base Select

  • aria-label now renders a hidden label and labels the trigger by that label plus itself (the APG select-only combobox pattern), so the accessible name keeps the current value: "Sort by, Requests" rather than "Sort by".
  • The name and id reach a custom trigger too, including the function form.
  • Spec updated to assert the labelling wiring, since the test library's name computation stops at the label for a self-referenced combobox while browsers include the option text.

Proposal editor

  • A new service with an empty name keeps a visible tab ("unnamed service") and shows an error on the name field, sharing the existing conflict-message path.

Base DescriptionList

  • String values get a title so text clipped by a narrow column is readable on hover.

@jdolle jdolle self-assigned this Sep 21, 2026
@jdolle
jdolle force-pushed the consolidate-tabs-review branch from 30c5d56 to e696fb1 Compare September 21, 2026 17:54
@theguild-bot

theguild-bot commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 11.14.1-alpha-20260921200319-1ca4b843dd8ff8c08b460d95184bf0b6fdbc6103 npm ↗︎ unpkg ↗︎

@jdolle jdolle mentioned this pull request Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tags: 11.14.1-alpha-1ca4b84, 1ca4b84, 1ca4b843dd8ff8c08b460d95184bf0b6fdbc6103

@jonathanawesome
jonathanawesome merged commit 8e188c9 into consolidate-tabs Sep 21, 2026
47 of 49 checks passed
@jonathanawesome
jonathanawesome deleted the consolidate-tabs-review branch September 21, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants