Consolidate tabs review - #8525
Merged
Merged
Conversation
jdolle
force-pushed
the
consolidate-tabs-review
branch
from
September 21, 2026 17:54
30c5d56 to
e696fb1
Compare
Collaborator
Merged
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
jonathanawesome
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
A review of the
consolidate-tabsbranch turned up a few regressions and gaps introduced by the migration fromui/tabsonto the Base UI components. This change addresses them; nothing here touches the seed script or the visual restyling.Description
Schema check page
DefaultSchemaViewandContractCheckVieware now hooks that return tab items, and the page renders a singleTabbedView, so switching graphs swaps the tabs instead of remounting the band the picker sits in.Schema version page
Base
Tabs/TabbedViewBase
Selectaria-labelnow renders a hidden label and labels the trigger by that label plus itself (the APG select-only combobox pattern), so the accessible name keeps the current value: "Sort by, Requests" rather than "Sort by".idreach a customtriggertoo, including the function form.Proposal editor
Base
DescriptionListtitleso text clipped by a narrow column is readable on hover.