Skip to content

Fix regressions from the button consolidation - #8527

Merged
jonathanawesome merged 2 commits into
consolidate-buttonfrom
consolidate-button-review
Sep 22, 2026
Merged

jonathanawesome merged 2 commits into
consolidate-buttonfrom
consolidate-button-review

Conversation

@jdolle

@jdolle jdolle commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Background

The button consolidation moved every button onto the base Button and replaced the old asChild slot with Base UI's render hook. A few call sites that used to merge extra classes onto the button were rewritten as wrappers around it, and a handful of icon and class swaps drifted from the original. Reviewing the branch against consolidate-form turned up the regressions below; this PR fixes them without changing the design decisions of the consolidation.

Description

  • Sign-in "last used" indicator: the shimmer overlay painted above the button and hid its label. The band is now translucent, and the Button itself is the tooltip trigger again so the hint is announced on the control. Applies to sign-up too via SignInButton.
  • SSO button: restored disabled={isPending} on the sign-in and sign-up SSO links.
  • Changelog trigger: the Popover trigger was a focusable span wrapping the button, giving keyboard users a dead tab stop and moving the popup state off the control. The Button is the trigger again; the wrapper and pulse dot sit outside the Popover.
  • "New collection" label: min-w-0 had moved inside the button, so the label overflowed instead of truncating. A min-w-0 flex wrapper with a full-width button restores the ellipsis.
  • "NO CHANGE" icon: the solid Diamond read as "component present"; it is dashed again to match the old Radix ComponentNoneIcon.
  • Explorer client-usage icon: back to 16px so the row height matches the usage button beside it.
  • Support ticket breadcrumb: the "Tickets" link has its heading typography back.

@jdolle jdolle self-assigned this Sep 21, 2026
@theguild-bot

theguild-bot commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 11.14.1-alpha-20260922190257-c7c26faf4d4f39135fdcd59a992592e68cd2d281 npm ↗︎ unpkg ↗︎

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tags: 11.14.1-alpha-c7c26fa, c7c26fa, c7c26faf4d4f39135fdcd59a992592e68cd2d281

@jdolle jdolle mentioned this pull request Sep 22, 2026
@jonathanawesome
jonathanawesome merged commit 259862d into consolidate-button Sep 22, 2026
48 of 49 checks passed
@jonathanawesome
jonathanawesome deleted the consolidate-button-review branch September 22, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants