Conversation
Author
|
Stacked follow-up: #2 adds digital framing separately and is a draft until this foundational model-support PR is merged. Framing-only review: p0ns/linkctl@feat/link2c-support...feat/link2c-digital-framing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recognize the Insta360 Link 2C (
2e1a:4c03) and enable the existing shared controls without treating this fixed-lens model as a motorized Link 2.This PR deliberately does not introduce digital framing commands. A dependent follow-up adds those separately.
Hardware evidence
A physical camera is detected as:
The camera owner manually verified zoom, focus, white balance, and brightness. Read-only checks also pass for status, info, and tracking. Pan/tilt are intentionally unsupported because the Link 2C has no motorized gimbal; successful firmware reads were not evidence of movement support.
Validation
Tested the exact standalone contents of this first commit, separately from the digital-framing working tree:
cargo fmt --checkcargo test— 65 passedcargo test --features hardware-tests -- --ignored readonly— 4 passed on the connected Link 2Ccargo clippy --all-targets --all-features -- -D warnings