Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack / review order
Depends on #1. Please merge the basic Link 2C support first.
This branch is stacked on
feat/link2c-support. Both branches live in a fork, so GitHub cannot use that fork-only branch as the base of an upstream PR. This is a draft against upstreammain; its full diff temporarily includes #1. After #1 merges, the branch can be rebased onto upstream main to leave only the framing commit.Framing-only review: p0ns/linkctl@feat/link2c-support...feat/link2c-digital-framing
Framing commit:
1923457.Summary
Add an explicit
framecommand for the fixed-lens Link 2C, separate from degree-based gimbal controls:0x07Auto Framing mode; reject unsupported/special/idle coordinate layouts.Protocol evidence
Recovered by static inspection of the official Insta360 Linux SDK, revision
2dd2c78186b0335a530042ae49accbef249d6a95. Full source links, binary SHA-256, symbol addresses, and decoding evidence are indocs/link2c-framing.md.0x13, SET_CUR; eight bytes: LE uint16 zoom/X/Y followed by movement/zoom step bytes.0x02; LE uint16 X/Y at offsets 38/40, not the setter's selector.Hardware validation
On a physical Link 2C (
2e1a:4c03):Tests
cargo fmt --checkcargo test— 72 passedcargo test --features hardware-tests -- --ignored readonly— 5 passedcargo clippy --all-targets --all-features -- -D warnings