Conversation
subsystem_get() returns one subsystem dict, but the probe passed it to list.extend(), which appends the dict's keys. The first element was then the string 'nqn' instead of the dict, so listener and namespace were always reported missing, even on a healthy device. Self-repair uses this probe twice: once to decide what to rebuild, once to check the result. It rebuilt nothing, called itself failed, and spent an attempt on every run. After five attempts the device is marked retries_exhausted and gets no more automatic repair.
mxsrc
requested changes
Sep 21, 2026
mxsrc
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch! With this in mind we can simplify further:
The whole _get_subsys is not required anymore, and subsys can simply be assigned the result of subsystem_get(...). It raises on errors, so the _safe wrapper is not required anymore. The list type is a left-over of the previous filtered subsystem_list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subsystem_get()returns a single subsystem dict, but the probe passed it tolist.extend(),which appends the dict's keys instead of the dict.
Listener and namespace were therefore always reported missing, even on a perfectly healthy device.
device_repair()calls this probe twice: once to decide what to rebuild, and onceafterwards to verify. Both calls got the same wrong answer, so:
Five of those and the device is marked retries_exhausted, which disables automatic repair for it permanently - including for a real failure later.
Self-repair therefore never confirmed success on any device since it was introduced in 6872469.
R26.3 only. main does not have the self-repair feature yet, so it does not have this bug.