Skip to content

fix(device): read the subsystem dict, not its keys #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BombermaG wants to merge 1 commit into
base: R26.3
Choose a base branch
from
Open

fix(device): read the subsystem dict, not its keys #1321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion simplyblock_core/controllers/device_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,13 @@ def _safe(label, fn):
subsys: list = []

def _get_subsys():
subsys.extend(rpc_client.subsystem_get(device_obj.nvmf_nqn) or [])
# subsystem_get() returns one subsystem dict, or None.
# list.extend(dict) would append the dict's keys instead of the dict.
entry = rpc_client.subsystem_get(device_obj.nvmf_nqn)
if isinstance(entry, dict):
subsys.append(entry)
elif entry:
subsys.extend(entry)
return subsys

_safe("subsystem", _get_subsys)
Expand Down